Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-05 Thread Hani Benhabiles
On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote: Il 05/06/2014 00:33, Hani Benhabiles ha scritto: IIUC, what this does is ensure that the other side gets a FIN before it gets a RST. Is this correct? Yes. Without shutdown(), this could be reproduced (unreliably) on

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-05 Thread Paolo Bonzini
Il 05/06/2014 11:58, Hani Benhabiles ha scritto: On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote: Il 05/06/2014 00:33, Hani Benhabiles ha scritto: IIUC, what this does is ensure that the other side gets a FIN before it gets a RST. Is this correct? Yes. Without shutdown(), this

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-04 Thread Hani Benhabiles
On Tue, Jun 03, 2014 at 01:33:41PM +0200, Paolo Bonzini wrote: Il 31/05/2014 23:39, Hani Benhabiles ha scritto: This forces finishing data sending to client before closing the socket like in exports listing or replying with NBD_REP_ERR_UNSUP cases. Signed-off-by: Hani Benhabiles

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-04 Thread Paolo Bonzini
Il 05/06/2014 00:33, Hani Benhabiles ha scritto: IIUC, what this does is ensure that the other side gets a FIN before it gets a RST. Is this correct? Yes. Without shutdown(), this could be reproduced (unreliably) on multiple tries. This is done in nbd_client_close() too, for the same reasons

Re: [Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-06-03 Thread Paolo Bonzini
Il 31/05/2014 23:39, Hani Benhabiles ha scritto: This forces finishing data sending to client before closing the socket like in exports listing or replying with NBD_REP_ERR_UNSUP cases. Signed-off-by: Hani Benhabiles h...@linux.com --- blockdev-nbd.c | 1 + qemu-nbd.c | 1 + 2 files

[Qemu-devel] [PATCH 3/3] nbd: Shutdown socket before closing.

2014-05-31 Thread Hani Benhabiles
This forces finishing data sending to client before closing the socket like in exports listing or replying with NBD_REP_ERR_UNSUP cases. Signed-off-by: Hani Benhabiles h...@linux.com --- blockdev-nbd.c | 1 + qemu-nbd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/blockdev-nbd.c