Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread Greg Kurz
On Fri, 15 Sep 2017 07:15:41 +0200 Thomas Huth wrote: > On 14.09.2017 21:25, Greg Kurz wrote: > > The following capabilities are VM specific: > > - KVM_CAP_PPC_SMT_POSSIBLE > > - KVM_CAP_PPC_HTAB_FD > > BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we >

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread Thomas Huth
On 15.09.2017 10:43, Greg Kurz wrote: > On Fri, 15 Sep 2017 07:15:41 +0200 > Thomas Huth wrote: > >> On 14.09.2017 21:25, Greg Kurz wrote: >>> The following capabilities are VM specific: >>> - KVM_CAP_PPC_SMT_POSSIBLE >>> - KVM_CAP_PPC_HTAB_FD >> >> BTW, looks like

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread David Gibson
On Fri, Sep 15, 2017 at 10:18:49AM +0200, Thomas Huth wrote: > On 15.09.2017 08:35, David Gibson wrote: > > On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote: > >> On 14.09.2017 21:25, Greg Kurz wrote: > >>> The following capabilities are VM specific: > >>> - KVM_CAP_PPC_SMT_POSSIBLE >

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread Thomas Huth
On 15.09.2017 08:35, David Gibson wrote: > On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote: >> On 14.09.2017 21:25, Greg Kurz wrote: >>> The following capabilities are VM specific: >>> - KVM_CAP_PPC_SMT_POSSIBLE >>> - KVM_CAP_PPC_HTAB_FD >> >> BTW, looks like kvmppc_has_cap_htab_fd()

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread David Gibson
On Thu, Sep 14, 2017 at 09:25:43PM +0200, Greg Kurz wrote: > The following capabilities are VM specific: > - KVM_CAP_PPC_SMT_POSSIBLE > - KVM_CAP_PPC_HTAB_FD > - KVM_CAP_PPC_ALLOC_HTAB > > If both KVM HV and KVM PR are present, checking them always return > the HV value, even if we explicitely

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-15 Thread David Gibson
On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote: > On 14.09.2017 21:25, Greg Kurz wrote: > > The following capabilities are VM specific: > > - KVM_CAP_PPC_SMT_POSSIBLE > > - KVM_CAP_PPC_HTAB_FD > > BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we > either remove it

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-14 Thread Thomas Huth
On 14.09.2017 21:25, Greg Kurz wrote: > The following capabilities are VM specific: > - KVM_CAP_PPC_SMT_POSSIBLE > - KVM_CAP_PPC_HTAB_FD BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we either remove it or check it somewhere? > - KVM_CAP_PPC_ALLOC_HTAB > > If both KVM HV and

[Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-14 Thread Greg Kurz
The following capabilities are VM specific: - KVM_CAP_PPC_SMT_POSSIBLE - KVM_CAP_PPC_HTAB_FD - KVM_CAP_PPC_ALLOC_HTAB If both KVM HV and KVM PR are present, checking them always return the HV value, even if we explicitely requested to use PR. This has no visible effect for