[Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-25 Thread Luiz Capitulino
Also fixes a few issues while there: 1. The fd returned by monitor_get_fd() leaks in most error conditions 2. monitor_get_fd() return value is not checked. Best case we get an error that is not correctly reported, worse case one of the functions using the fd (with value of -1) will explo

Re: [Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 25 Sep 2012 13:29:32 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Also fixes a few issues while there: >> > >> > 1. The fd returned by monitor_get_fd() leaks in most error conditions >> > 2. monitor_get_fd() return value is not check

Re: [Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-25 Thread Luiz Capitulino
On Tue, 25 Sep 2012 13:29:32 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Also fixes a few issues while there: > > > > 1. The fd returned by monitor_get_fd() leaks in most error conditions > > 2. monitor_get_fd() return value is not checked. Best case we get > > an error

Re: [Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-25 Thread Markus Armbruster
Luiz Capitulino writes: > Also fixes a few issues while there: > > 1. The fd returned by monitor_get_fd() leaks in most error conditions > 2. monitor_get_fd() return value is not checked. Best case we get > an error that is not correctly reported, worse case one of the > functions using

[Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-24 Thread Luiz Capitulino
Also fixes a few issues while there: 1. The fd returned by monitor_get_fd() leaks in most error conditions 2. monitor_get_fd() return value is not checked. Best case we get an error that is not correctly reported, worse case one of the functions using the fd (with value of -1) will explo

[Qemu-devel] [PATCH 3/3] qapi: convert add_client

2012-09-20 Thread Luiz Capitulino
Also fixes a few issues while there: 1. The fd returned by monitor_get_fd() leaks in most error conditions 2. monitor_get_fd() return value is not checked. Best case we get an error that is not correctly reported, worse case one of the functions using the fd (with value of -1) will explo