Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x

2015-01-01 Thread Laurent Vivier
Hi Andreas, Thank you for your comments. You're right: I will change the subject and distinguish the instance_init and realize. dp83932_init() is used in a single place, so as you propose I will inline it and remove the function definition. Regards, Laurent Le 01/01/2015 17:15, Andreas Färber

Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x

2015-01-01 Thread Andreas Färber
Hi Laurent, Am 29.12.2014 um 01:39 schrieb Laurent Vivier: > Signed-off-by: Laurent Vivier > --- > hw/mips/mips_jazz.c | 2 +- > hw/net/dp8393x.c | 182 > +++ > include/hw/net/dp8393x.h | 1 - > 3 files changed, 121 insertions(+), 64

[Qemu-devel] [PATCH 3/3] qdev'ify dp8393x

2014-12-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- hw/mips/mips_jazz.c | 2 +- hw/net/dp8393x.c | 182 +++ include/hw/net/dp8393x.h | 1 - 3 files changed, 121 insertions(+), 64 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c index