Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-05-04 Thread Kevin Wolf
Am 03.05.2010 19:01, schrieb Anthony Liguori: > On 03/29/2010 06:03 AM, Kevin Wolf wrote: >> Am 28.03.2010 19:07, schrieb Ryota Ozaki: >> >>> - use err(3) instead of errx(3) if errno is available >>>to report why failed >>> - let fail prior to daemon(3) if opening a nbd file >>>is likel

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-05-03 Thread Anthony Liguori
On 03/29/2010 06:03 AM, Kevin Wolf wrote: Am 28.03.2010 19:07, schrieb Ryota Ozaki: - use err(3) instead of errx(3) if errno is available to report why failed - let fail prior to daemon(3) if opening a nbd file is likely to fail after daemonizing to avoid silent failure exit - add m

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-05-02 Thread Ryota Ozaki
On Mon, Mar 29, 2010 at 8:03 PM, Kevin Wolf wrote: > Am 28.03.2010 19:07, schrieb Ryota Ozaki: >> - use err(3) instead of errx(3) if errno is available >>   to report why failed >> - let fail prior to daemon(3) if opening a nbd file >>   is likely to fail after daemonizing to avoid silent >>   fai

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-03-29 Thread Kevin Wolf
Am 28.03.2010 19:07, schrieb Ryota Ozaki: > - use err(3) instead of errx(3) if errno is available > to report why failed > - let fail prior to daemon(3) if opening a nbd file > is likely to fail after daemonizing to avoid silent > failure exit > - add missing 'ret = 1' when unix_socket_outgoi

[Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-03-28 Thread Ryota Ozaki
- use err(3) instead of errx(3) if errno is available to report why failed - let fail prior to daemon(3) if opening a nbd file is likely to fail after daemonizing to avoid silent failure exit - add missing 'ret = 1' when unix_socket_outgoing failed Signed-off-by: Ryota Ozaki --- qemu-nbd.c

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-03-28 Thread Ryota Ozaki
On Sat, Mar 27, 2010 at 10:02 PM, Aurelien Jarno wrote: > On Sat, Mar 20, 2010 at 03:23:24PM +0900, Ryota Ozaki wrote: >> - use err(3) instead of errx(3) if errno is available >>   to report why failed >> - let fail prior to daemon(3) if opening a nbd file >>   is likely to fail after daemonizing

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-03-27 Thread Aurelien Jarno
On Sat, Mar 20, 2010 at 03:23:24PM +0900, Ryota Ozaki wrote: > - use err(3) instead of errx(3) if errno is available > to report why failed > - let fail prior to daemon(3) if opening a nbd file > is likely to fail after daemonizing to avoid silent > failure exit > > Signed-off-by: Ryota Ozak

[Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-03-19 Thread Ryota Ozaki
- use err(3) instead of errx(3) if errno is available to report why failed - let fail prior to daemon(3) if opening a nbd file is likely to fail after daemonizing to avoid silent failure exit Signed-off-by: Ryota Ozaki --- qemu-nbd.c | 16 +++- 1 files changed, 11 insertions(