Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-09 Thread Corey Minyard
On 10/09/2014 05:07 AM, Paolo Bonzini wrote: >> +error_setg_errno(&err, errno, "Error connecting to socket"); >> > closesocket(s->fd); >> > s->fd = rc; >> > } > This is missing above this hunk: > > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index e6a9644

Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-09 Thread Paolo Bonzini
Il 08/10/2014 14:11, miny...@acm.org ha scritto: > From: Corey Minyard > > An error value here would be quite handy and more consistent > with the rest of the code. > > Corey Minyard > --- > include/qemu/sockets.h | 2 +- > migration-tcp.c| 4 ++-- > migration-unix.c | 4 ++--

[Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-08 Thread minyard
From: Corey Minyard An error value here would be quite handy and more consistent with the rest of the code. Corey Minyard --- include/qemu/sockets.h | 2 +- migration-tcp.c| 4 ++-- migration-unix.c | 4 ++-- qemu-char.c| 6 +++--- util/qemu-sockets.c| 19