Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Alexander Graf
On 25.04.14 14:56, Thomas Huth wrote: On Fri, 25 Apr 2014 14:36:11 +0200 Alexander Graf wrote: On 25.04.14 14:15, Thomas Huth wrote: On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf wrote: [...] I also think we should rather align the code with the PTE handling somehow. This way it gets p

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
On Fri, 25 Apr 2014 14:36:11 +0200 Alexander Graf wrote: > > On 25.04.14 14:15, Thomas Huth wrote: > > > > On Thu, 24 Apr 2014 18:36:18 +0200 > > Alexander Graf wrote: [...] > >> I also think we should rather align the > >> code with the PTE handling somehow. This way it gets pretty confusing to

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Alexander Graf
On 25.04.14 14:15, Thomas Huth wrote: Hi Alex, On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf wrote: On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. ... diff --gi

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
Hi Alex, On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf wrote: > > On 24.04.14 17:34, Jens Freimann wrote: > > From: Thomas Huth > > > > With the EDAT-1 facility, the MMU translation can stop at the > > segment table already, pointing to a 1 MB block. ... > > diff --git a/target-s390x/help

[Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/cpu.h| 4 target-s390x/helper.c | 4 2 files

[Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/helper.c | 4 1 file changed, 4 insertions(+) diff --

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Alexander Graf
On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/cpu.h| 4 ++

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
On 04/24/2014 03:40 PM, Alexander Graf wrote: On 24.04.14 10:51, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Alexander Graf
On 24.04.14 10:51, Jens Freimann wrote: From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/helper.c | 4 ++