Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/25/2015 08:55 AM, Stefan Hajnoczi wrote: > On Mon, Nov 16, 2015 at 03:36:58PM +0100, Hannes Reinecke > wrote: >> +/* Enable TGPS bit */ +if (s->wwn) + >> outbuf[4] = 1; > > QEMU coding style: Please always use curly braces, even if the

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

On Mon, Nov 16, 2015 at 03:36:58PM +0100, Hannes Reinecke wrote: > +/* Enable TGPS bit */ > +if (s->wwn) > +outbuf[4] = 1; QEMU coding style: Please always use curly braces, even if the if statement body is just one line. > +static void

[Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

Implement support for REPORT TARGET PORT GROUPS scsi command. Note that target port groups are referenced per SCSI wwn , which might be connected to different hosts. So we need to walk the entire qtree to find all eligible SCSI devices. Signed-off-by: Hannes Reinecke ---