Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-29 Thread David Gibson
On Wed, May 25, 2011 at 05:13:40PM +0200, Markus Armbruster wrote: > David Gibson writes: > > > On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: > >> Signed-off-by: Paolo Bonzini > >> Cc: Alexander Graf > >> Cc: David Gibson > >> --- > >> hw/spapr_vio.c |8 +++- > >> 1 f

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-29 Thread David Gibson
On Wed, May 25, 2011 at 09:30:22AM +0200, Paolo Bonzini wrote: > On 05/25/2011 12:14 AM, David Gibson wrote: > >I don't see what the point of this is. Absolute irq numbers have no > >special meaning in the XICS context, and the guest kernel will remap > >them to virtual irqs anyway. > > It allows

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-25 Thread Markus Armbruster
David Gibson writes: > On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> Cc: Alexander Graf >> Cc: David Gibson >> --- >> hw/spapr_vio.c |8 +++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/hw/spapr_vio.c b/hw

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 12:14 AM, David Gibson wrote: I don't see what the point of this is. Absolute irq numbers have no special meaning in the XICS context, and the guest kernel will remap them to virtual irqs anyway. It allows you to see the irq in "info qtree" for example. Paolo

Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-24 Thread David Gibson
On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Cc: Alexander Graf > Cc: David Gibson > --- > hw/spapr_vio.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c > index be535d6..fee

[Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev

2011-05-24 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Cc: Alexander Graf Cc: David Gibson --- hw/spapr_vio.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c index be535d6..fee4c46 100644 --- a/hw/spapr_vio.c +++ b/hw/spapr_vio.c @@ -52,6 +52,10 @@ static