Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-18 Thread Richard Henderson
On 6/18/19 5:06 AM, Bastian Koppelmann wrote: >> Have a look at the end of thumb_tr_translate_insn & insn_crosses_page to see >> how to handle this properly. > > I copied it more or less from target/riscv. I guess that needs fixing as well > :) Yes, I noticed the riscv problem during review of t

Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-18 Thread Bastian Koppelmann
On 6/17/19 6:45 PM, Richard Henderson wrote: On 6/17/19 7:35 AM, Bastian Koppelmann wrote: +static void tricore_tr_init_disas_context(DisasContextBase *dcbase, + CPUState *cs) { +DisasContext *ctx = container_of(dcbase, DisasContext, base);

Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-17 Thread Richard Henderson
On 6/17/19 7:35 AM, Bastian Koppelmann wrote: > +static void tricore_tr_init_disas_context(DisasContextBase *dcbase, > + CPUState *cs) > { > +DisasContext *ctx = container_of(dcbase, DisasContext, base); > CPUTriCoreState *env = cs->env_ptr; > +

Re: [Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-17 Thread Richard Henderson
On 6/17/19 7:35 AM, Bastian Koppelmann wrote: > +static void tricore_tr_translate_insn(DisasContextBase *dcbase, CPUState > *cpu) > +{ > +DisasContext *ctx = container_of(dcbase, DisasContext, base); > +CPUTriCoreState *env = cpu->env_ptr; > + > +ctx->opcode = cpu_ldl_code(env, ctx->ba

[Qemu-devel] [PATCH 3/3] target/tricore: Use translate_loop

2019-06-17 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c | 117 +++-- 1 file changed, 74 insertions(+), 43 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c index b4e332777a..f3b297639a 100644 --- a/target/tricore/translate.