Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 27.05.2013 23:14, Laurent Desnogues wrote: > > > On Monday, May 27, 2013, Richard Henderson > wrote: >> On 2013-05-27 04:43, Claudio Fontana wrote: Hmm, true. Although I'd been thinking more along the lines of arranging the code such that we'd use movz

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On Tue, May 28, 2013 at 3:01 PM, Claudio Fontana wrote: > On 27.05.2013 23:14, Laurent Desnogues wrote: >> >> >> On Monday, May 27, 2013, Richard Henderson > > wrote: >>> On 2013-05-27 04:43, Claudio Fontana wrote: > > Hmm, true. Although I'd been thinking more al

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On Monday, May 27, 2013, Richard Henderson wrote: > On 2013-05-27 04:43, Claudio Fontana wrote: >>> >>> Hmm, true. Although I'd been thinking more along the lines of >>> arranging the code such that we'd use movz to set the zero. >> >> I think we need to keep treating zero specially if we want to

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 14.05.2013 17:19, Richard Henderson wrote: > On 05/14/2013 05:25 AM, Peter Maydell wrote: >>> Yes, I agree. I could not find an image which triggered that code path for register rotation amounts. >> Try PPC : rlwmn will generate a rotl (as will other insns). >> > > rlwmn will only generate

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 05/14/2013 08:16 AM, Richard Henderson wrote: > On 05/14/2013 07:05 AM, Claudio Fontana wrote: >>> Conditional branch range is +-1MB. You'll never see a TB that large. You >>> don't need to emit a branch-across-branch. >> >> Is there maybe a way to do it right even in the corner case where we

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 05/14/2013 05:25 AM, Peter Maydell wrote: >> Yes, I agree. I could not find an image which triggered that >> > code path for register rotation amounts. > Try PPC : rlwmn will generate a rotl (as will other insns). > rlwmn will only generate constant rotations; at issue are variable rotations.

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 05/14/2013 07:05 AM, Claudio Fontana wrote: >> Conditional branch range is +-1MB. You'll never see a TB that large. You >> don't need to emit a branch-across-branch. > > Is there maybe a way to do it right even in the corner case where we have > a huge list of hundreds of thousands of instruc

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 13.05.2013 21:49, Richard Henderson wrote: > On 05/13/2013 06:33 AM, Claudio Fontana wrote: >> +enum aarch64_cond_code { >> +COND_EQ = 0x0, >> +COND_NE = 0x1, >> +COND_CS = 0x2, /* Unsigned greater or equal */ >> +COND_HS = 0x2, /* ALIAS greater or equal */ > > Clearer to

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On Tue, May 14, 2013 at 2:01 PM, Claudio Fontana wrote: [...] >>> +static void tcg_target_qemu_prologue(TCGContext *s) >>> +{ >>> +int r; >>> +int frame_size; /* number of 16 byte items */ >>> + >>> +/* we need to save (FP, LR) and X19 to X28 */ >>> +frame_size = (1) + (TCG_REG_X27

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 14 May 2013 13:01, Claudio Fontana wrote: > On 13.05.2013 20:28, Peter Maydell wrote: >> On 13 May 2013 14:33, Claudio Fontana wrote: >>> >>> add preliminary support for TCG target aarch64. >> >> Thanks for this patch. Some comments below. >> >>> Signed-off-by: Claudio Fontana >>> --- >>> in

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 13.05.2013 20:28, Peter Maydell wrote: > On 13 May 2013 14:33, Claudio Fontana wrote: >> >> add preliminary support for TCG target aarch64. > > Thanks for this patch. Some comments below. > >> Signed-off-by: Claudio Fontana >> --- >> include/exec/exec-all.h |5 +- >> tcg/aarch64/tcg-ta

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 05/13/2013 06:33 AM, Claudio Fontana wrote: > +enum aarch64_cond_code { > +COND_EQ = 0x0, > +COND_NE = 0x1, > +COND_CS = 0x2, /* Unsigned greater or equal */ > +COND_HS = 0x2, /* ALIAS greater or equal */ Clearer to define aliases as COND_HS = COND_CS. > +static inline v

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

On 13 May 2013 14:33, Claudio Fontana wrote: > > add preliminary support for TCG target aarch64. Thanks for this patch. Some comments below. > Signed-off-by: Claudio Fontana > --- > include/exec/exec-all.h |5 +- > tcg/aarch64/tcg-target.c | 1084 > +++

[Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

add preliminary support for TCG target aarch64. Signed-off-by: Claudio Fontana --- include/exec/exec-all.h |5 +- tcg/aarch64/tcg-target.c | 1084 ++ tcg/aarch64/tcg-target.h | 106 + 3 files changed, 1194 insertions(+), 1 deletion(-) creat