Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-15 Thread David Hildenbrand
On 15.07.19 09:22, Pankaj Gupta wrote: > >> >> On 12.07.19 09:35, Pankaj Gupta wrote: >>> Remove transactional & non transactional device info >>> for virtio pmem. >> >> Can you explain and add *why* ? > > As per upstream suggestion by Cornelia & MST, transactional devices are for > legacy purpos

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-15 Thread Pankaj Gupta
> > On 12.07.19 09:35, Pankaj Gupta wrote: > > Remove transactional & non transactional device info > > for virtio pmem. > > Can you explain and add *why* ? As per upstream suggestion by Cornelia & MST, transactional devices are for legacy purpose. So, does not make sense for virtio-pmem. Tha

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-14 Thread David Hildenbrand
On 12.07.19 09:35, Pankaj Gupta wrote: > Remove transactional & non transactional device info > for virtio pmem. Can you explain and add *why* ? > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/virtio/virtio-pmem

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Pankaj Gupta
> > On Fri, 12 Jul 2019 13:05:54 +0530 > Pankaj Gupta wrote: > > > Remove transactional & non transactional device info > > for virtio pmem. > > s/device info/names/ ? yes. > > > > > Signed-off-by: Pankaj Gupta > > --- > > hw/virtio/virtio-pmem-pci.c | 2 -- > > 1 file changed, 2 deleti

Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:54 +0530 Pankaj Gupta wrote: > Remove transactional & non transactional device info > for virtio pmem. s/device info/names/ ? > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

2019-07-12 Thread Pankaj Gupta
Remove transactional & non transactional device info for virtio pmem. Signed-off-by: Pankaj Gupta --- hw/virtio/virtio-pmem-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c index 0da6627469..fe2af00fa1 100644 --- a/hw/virtio/vi