Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-28 Thread Stefano Stabellini
On Mon, 27 Jun 2011, Kevin Wolf wrote: Am 27.06.2011 17:34, schrieb Stefano Stabellini: On Mon, 27 Jun 2011, Kevin Wolf wrote: hw/ide/pci.h is just as internal as internal.h is. And even if you managed to access the same things without any IDE header file, I still think it's not the right

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Kevin Wolf
Am 23.06.2011 15:16, schrieb Stefano Stabellini: On Mon, 20 Jun 2011, Kevin Wolf wrote: diff --git a/hw/xen_platform.c b/hw/xen_platform.c index b167eee..9f8c843 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -34,6 +34,9 @@ #include xen_backend.h #include rwhandler.h #include

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Stefano Stabellini
On Mon, 27 Jun 2011, Kevin Wolf wrote: hw/ide/pci.h is just as internal as internal.h is. And even if you managed to access the same things without any IDE header file, I still think it's not the right level of abstraction because it relies on the implementation details of IDE. Just this

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-27 Thread Kevin Wolf
Am 27.06.2011 17:34, schrieb Stefano Stabellini: On Mon, 27 Jun 2011, Kevin Wolf wrote: hw/ide/pci.h is just as internal as internal.h is. And even if you managed to access the same things without any IDE header file, I still think it's not the right level of abstraction because it relies on

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-23 Thread Stefano Stabellini
On Mon, 20 Jun 2011, Kevin Wolf wrote: diff --git a/hw/xen_platform.c b/hw/xen_platform.c index b167eee..9f8c843 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -34,6 +34,9 @@ #include xen_backend.h #include rwhandler.h #include trace.h +#include hw/ide/internal.h

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-20 Thread Michael S. Tsirkin
On Thu, Jun 16, 2011 at 05:05:19PM +0100, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before

Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-20 Thread Kevin Wolf
Am 20.06.2011 10:28, schrieb Alexander Graf: On 16.06.2011, at 18:05, stefano.stabell...@eu.citrix.com stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers

[Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform

2011-06-16 Thread stefano.stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com The unplug protocol is necessary to support PV drivers in the guest: the drivers expect to be able to unplug emulated disks and nics before initializing the Xen PV interfaces. It is responsibility of the guest to make sure that the unplug