Re: [Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-06 Thread Peter Xu
On Fri, Jun 02, 2017 at 06:55:30PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > To make things easier, I just moved it to populate_ram_info(). > > Blk is not RAM; better to create a separate function. Agree... Maybe rename populate_ram_info() into more

Re: [Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > To make things easier, I just moved it to populate_ram_info(). Blk is not RAM; better to create a separate function. Dave > Signed-off-by: Juan Quintela > --- > migration/migration.c | 26 -- > 1 file changed, 8 insertions(

Re: [Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-02 Thread Eric Blake
On 06/01/2017 04:40 PM, Juan Quintela wrote: > To make things easier, I just moved it to populate_ram_info(). > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 26 -- > 1 file changed, 8 insertions(+), 18 deletions(-) > Reviewed-by: Eric Blake -- Eric B

[Qemu-devel] [PATCH 3/4] ram: Print block stats also in the complete case

2017-06-01 Thread Juan Quintela
To make things easier, I just moved it to populate_ram_info(). Signed-off-by: Juan Quintela --- migration/migration.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 7f79da0..8289544 100644 --- a/