Re: [Qemu-devel] [PATCH 3/4] s390x/css: remove dubious error handling branch

2017-09-12 Thread Cornelia Huck
On Mon, 11 Sep 2017 15:08:52 +0200 Halil Pasic wrote: > On 09/11/2017 11:48 AM, Cornelia Huck wrote: > > On Fri, 8 Sep 2017 17:24:45 +0200 > > Halil Pasic wrote: > >> The case in question actually never happens. Let us get rid of the dead > >> code. > > > > I had tried to be complete in my

Re: [Qemu-devel] [PATCH 3/4] s390x/css: remove dubious error handling branch

2017-09-11 Thread Halil Pasic
On 09/11/2017 11:48 AM, Cornelia Huck wrote: > On Fri, 8 Sep 2017 17:24:45 +0200 > Halil Pasic wrote: > > s/dubious/unused/ > Nod. >> The case in question actually never happens. Let us get rid of the dead >> code. > > I had tried to be complete in my initial implementation. With the > cur

Re: [Qemu-devel] [PATCH 3/4] s390x/css: remove dubious error handling branch

2017-09-11 Thread Cornelia Huck
On Fri, 8 Sep 2017 17:24:45 +0200 Halil Pasic wrote: s/dubious/unused/ > The case in question actually never happens. Let us get rid of the dead > code. I had tried to be complete in my initial implementation. With the current implementation, it can never happen, yes. We can easily resurrect i

[Qemu-devel] [PATCH 3/4] s390x/css: remove dubious error handling branch

2017-09-08 Thread Halil Pasic
The case in question actually never happens. Let us get rid of the dead code. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index a44d87ab3e..a9cdd54efc 100644 --- a/hw/s390x/css.c +++ b/hw/s390x/css.c @@ -