Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:16, Edgar E. Iglesias wrote: > On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: >> On 12 February 2016 at 15:12, Edgar E. Iglesias >> wrote: >> > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: >> >> The user-mode versions of get/set_r13_bank

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Sergey Fedorov
On 12.02.2016 18:16, Edgar E. Iglesias wrote: > On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: >> On 12 February 2016 at 15:12, Edgar E. Iglesias >> wrote: >>> On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: The user-mode versions of get/set_r13_banked() exist j

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: > On 12 February 2016 at 15:12, Edgar E. Iglesias > wrote: > > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > >> The user-mode versions of get/set_r13_banked() exist just to assert > >> if they're ever called -- the t

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Fri, Feb 12, 2016 at 04:12:18PM +0100, Edgar E. Iglesias wrote: > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > > The user-mode versions of get/set_r13_banked() exist just to assert > > if they're ever called -- the translate time code should never > > emit calls to them becau

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:12, Edgar E. Iglesias wrote: > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: >> The user-mode versions of get/set_r13_banked() exist just to assert >> if they're ever called -- the translate time code should never >> emit calls to them because SRS from us

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > The user-mode versions of get/set_r13_banked() exist just to assert > if they're ever called -- the translate time code should never > emit calls to them because SRS from user mode always UNDEF. > There's no code in the softmmu versio

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Sergey Fedorov
On 11.02.2016 22:11, Peter Maydell wrote: > The user-mode versions of get/set_r13_banked() exist just to assert > if they're ever called -- the translate time code should never > emit calls to them because SRS from user mode always UNDEF. > There's no code in the softmmu versions that can't compile

[Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-11 Thread Peter Maydell
The user-mode versions of get/set_r13_banked() exist just to assert if they're ever called -- the translate time code should never emit calls to them because SRS from user mode always UNDEF. There's no code in the softmmu versions that can't compile in CONFIG_USER_ONLY, so combine the two functions