[Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-23 Thread Luiz Capitulino
It's not needed. Besides we can then assume that bdrv_eject() is only called when there's a tray state change, which is useful to the DEVICE_TRAY_MOVED event (going to be added in a future commit). Signed-off-by: Luiz Capitulino Reviewed-by: Markus Armbruster Acked-by: Kevin Wolf --- hw/ide/at

Re: [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-20 Thread Markus Armbruster
Luiz Capitulino writes: > It's not needed. Besides we can then assume that bdrv_eject() is > only called when there's a tray state change, which is useful to > the DEVICE_TRAY_MOVED event (going to be added in a future > commit). We can assume that only after the next patch "ide: drop ide_tray_s

[Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-17 Thread Luiz Capitulino
It's not needed. Besides we can then assume that bdrv_eject() is only called when there's a tray state change, which is useful to the DEVICE_TRAY_MOVED event (going to be added in a future commit). Signed-off-by: Luiz Capitulino --- hw/ide/atapi.c |7 +-- hw/scsi-disk.c |7 +-- 2