Re: [Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-29 Thread Paolo Bonzini
Il 29/07/2014 08:28, Fam Zheng ha scritto: >> > + >> > +default: >> > +break; > Out of curiosity, why add this default branch? No particular reason, I guess I've changed my style since I wrote this code! Paolo

Re: [Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-28 Thread Fam Zheng
On Mon, 07/28 17:08, Paolo Bonzini wrote: > This will be used for both scsi_block_new_request and the scsi-block > implementation of parse_cdb. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/scsi-disk.c | 38 ++ > 1 file changed, 26 insertions(+), 12 deletio

[Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-28 Thread Paolo Bonzini
This will be used for both scsi_block_new_request and the scsi-block implementation of parse_cdb. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-d

[Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-16 Thread Paolo Bonzini
This will be used for both scsi_block_new_request and the scsi-block implementation of parse_cdb. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-d