Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-13 Thread Halil Pasic
On 09/13/2017 11:58 AM, Cornelia Huck wrote: > On Mon, 11 Sep 2017 20:14:59 +0200 > Halil Pasic wrote: > >> On 09/06/2017 02:42 PM, Cornelia Huck wrote: @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) } else { virtio_bus_get_vdev_config

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-13 Thread Cornelia Huck
On Mon, 11 Sep 2017 20:14:59 +0200 Halil Pasic wrote: > On 09/06/2017 02:42 PM, Cornelia Huck wrote: > >> @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) > >> } else { > >> virtio_bus_get_vdev_config(&dev->bus, vdev->config); > >> /* XXX co

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-11 Thread Halil Pasic
On 09/06/2017 02:42 PM, Cornelia Huck wrote: >> @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) >> } else { >> virtio_bus_get_vdev_config(&dev->bus, vdev->config); >> /* XXX config space endianness */ > Unrelated: That should be fine, I gue

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-06 Thread Cornelia Huck
On Wed, 6 Sep 2017 14:49:52 +0200 Halil Pasic wrote: > On 09/06/2017 02:42 PM, Cornelia Huck wrote: > > On Tue, 5 Sep 2017 13:16:43 +0200 > > Halil Pasic wrote: > >> @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) > >> } else { > >> virtio_bus_get_vd

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-06 Thread Halil Pasic
On 09/06/2017 02:42 PM, Cornelia Huck wrote: > On Tue, 5 Sep 2017 13:16:43 +0200 > Halil Pasic wrote: > >> Replace direct access which implicitly assumes no IDA >> or MIDA with the new ccw data stream interface which should >> cope with these transparently in the future. >> >> Signed-off-by: H

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-06 Thread Cornelia Huck
On Tue, 5 Sep 2017 13:16:43 +0200 Halil Pasic wrote: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > > --- > > Error handling: At the moment w

[Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

2017-09-05 Thread Halil Pasic
Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic --- Error handling: At the moment we ignore errors reported by stream ops to keep the change minimal. It migh