Paolo Bonzini writes:
> On 25/02/2016 16:03, Lluís Vilanova wrote:
>> static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
>> {
>> -int id = trace_event_get_id(ev);
>> +TraceEventID id;
>> +assert(ev != NULL);
> Please don't add "!= NULL" asserts. The reason of a crash wo
On 25/02/2016 16:03, Lluís Vilanova wrote:
> static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
> {
> -int id = trace_event_get_id(ev);
> +TraceEventID id;
> +assert(ev != NULL);
Please don't add "!= NULL" asserts. The reason of a crash would be
pretty obvious from t
On Thu, Feb 25, 2016 at 04:03:00PM +0100, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova
> ---
> trace/control-internal.h |8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
Signed-off-by: Lluís Vilanova
---
trace/control-internal.h |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/trace/control-internal.h b/trace/control-internal.h
index c78a45a..d1f99e3 100644
--- a/trace/control-internal.h
+++ b/trace/control-internal.h
@@ -58,14 +58,1
