Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 10:16 PM, Richard Henderson wrote: > On 02/12/2010 11:47 AM, Blue Swirl wrote: >> >> Please make separate patches for unrelated changes. Now the essence of >> the patch is very hard to see. Also pure formatting changes are not >> very useful. > > Is this just about page_get

Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Richard Henderson
On 02/12/2010 11:47 AM, Blue Swirl wrote: Please make separate patches for unrelated changes. Now the essence of the patch is very hard to see. Also pure formatting changes are not very useful. Is this just about page_get_flags, or was there some other pure formatting change to which you objec

Re: [Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 12:57 AM, Richard Henderson wrote: > The addr < end comparison prevents the last page from being > iterated; an iteration based on length avoids this problem. Please make separate patches for unrelated changes. Now the essence of the patch is very hard to see. Also pure fo

[Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-11 Thread Richard Henderson
The addr < end comparison prevents the last page from being iterated; an iteration based on length avoids this problem. --- exec.c | 54 +++--- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/exec.c b/exec.c index 766568b..ebbe6d0