Re: [Qemu-devel] [PATCH 3/6] block: Remove BDRV_O_COPY_ON_READ for bs->file

2014-04-29 Thread Max Reitz
On 25.04.2014 19:51, Kevin Wolf wrote: Copy on Read makes sense on the format level where backing files are implemented, but it's not required on the protocol level. While it shouldn't actively break anything to have COR enabled on both layers, needless serialisation and allocation checks may imp

[Qemu-devel] [PATCH 3/6] block: Remove BDRV_O_COPY_ON_READ for bs->file

2014-04-25 Thread Kevin Wolf
Copy on Read makes sense on the format level where backing files are implemented, but it's not required on the protocol level. While it shouldn't actively break anything to have COR enabled on both layers, needless serialisation and allocation checks may impact performance. Signed-off-by: Kevin Wo