Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Kevin Wolf
Am 05.10.2011 18:17, schrieb Stefan Hajnoczi: > The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). > They should go through bdrv_co_do_readv() and bdrv_co_do_writev() > instead in order to unify request processing code across sync, aio, and > coroutine interfaces. This is also

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Zhi Yong Wu
On Wed, Oct 12, 2011 at 5:03 PM, Stefan Hajnoczi wrote: > On Tue, Oct 11, 2011 at 7:44 AM, Zhi Yong Wu wrote: >> On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi >> wrote: >>> @@ -1101,36 +1144,7 @@ static void set_dirty_bitmap(BlockDriverState *bs, >>> int64_t sector_num, >>>  int bdrv_write(B

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 7:44 AM, Zhi Yong Wu wrote: > On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi > wrote: >> @@ -1101,36 +1144,7 @@ static void set_dirty_bitmap(BlockDriverState *bs, >> int64_t sector_num, >>  int bdrv_write(BlockDriverState *bs, int64_t sector_num, >>                const

Re: [Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-10 Thread Zhi Yong Wu
On Thu, Oct 6, 2011 at 12:17 AM, Stefan Hajnoczi wrote: > The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). > They should go through bdrv_co_do_readv() and bdrv_co_do_writev() > instead in order to unify request processing code across sync, aio, and > coroutine interfaces.  T

[Qemu-devel] [PATCH 3/6] block: switch bdrv_read()/bdrv_write() to coroutines

2011-10-05 Thread Stefan Hajnoczi
The bdrv_read()/bdrv_write() functions call .bdrv_read()/.bdrv_write(). They should go through bdrv_co_do_readv() and bdrv_co_do_writev() instead in order to unify request processing code across sync, aio, and coroutine interfaces. This is also an important step towards removing BlockDriverState .