Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

2017-06-12 Thread Gerd Hoffmann
On Mon, 2017-06-12 at 13:37 +0200, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:18 +0100 > Mark Cave-Ayland wrote: > > > The dma_enabled property enables us to set the FW_CFG_ID version > > accordingly. > > it might be not safe as patch reorders FW_CFG_ID entry. > > (I recall there were pat

Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 12:37, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:18 +0100 > Mark Cave-Ayland wrote: > >> The dma_enabled property enables us to set the FW_CFG_ID version >> accordingly. > it might be not safe as patch reorders FW_CFG_ID entry. > > (I recall there were patches that sorted fwc

Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

2017-06-12 Thread Igor Mammedov
On Sat, 10 Jun 2017 13:30:18 +0100 Mark Cave-Ayland wrote: > The dma_enabled property enables us to set the FW_CFG_ID version > accordingly. it might be not safe as patch reorders FW_CFG_ID entry. (I recall there were patches that sorted fwcfg entries, but it's worth checking that it won't break

Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

2017-06-10 Thread Philippe Mathieu-Daudé
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote: The dma_enabled property enables us to set the FW_CFG_ID version accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()

2017-06-10 Thread Mark Cave-Ayland
The dma_enabled property enables us to set the FW_CFG_ID version accordingly. Signed-off-by: Mark Cave-Ayland --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 1313bfd..f7b78a9 100644 --- a/hw/