Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

2019-05-13 Thread Philippe Mathieu-Daudé
On 5/13/19 2:39 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 4/18/19 4:53 PM, Markus Armbruster wrote: >>> "Debugging with GDB / Appendix E GDB Remote Serial Protocol / >>> Overview" specifies "The printable characters '#' and '$' or with a >>> numeric value greater than

Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

2019-05-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/18/19 4:53 PM, Markus Armbruster wrote: >> "Debugging with GDB / Appendix E GDB Remote Serial Protocol / >> Overview" specifies "The printable characters '#' and '$' or with a >> numeric value greater than 126 must not be used." gdb_read_byte() >> only

Re: [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

2019-04-18 Thread Philippe Mathieu-Daudé
On 4/18/19 4:53 PM, Markus Armbruster wrote: > "Debugging with GDB / Appendix E GDB Remote Serial Protocol / > Overview" specifies "The printable characters '#' and '$' or with a > numeric value greater than 126 must not be used." gdb_read_byte() > only rejects values < 32. This is wrong.

[Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts

2019-04-18 Thread Markus Armbruster
"Debugging with GDB / Appendix E GDB Remote Serial Protocol / Overview" specifies "The printable characters '#' and '$' or with a numeric value greater than 126 must not be used." gdb_read_byte() only rejects values < 32. This is wrong. Impact depends on the caller: * gdb_handlesig() passes a