Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

2018-04-24 Thread Eric Blake
On 04/24/2018 12:19 PM, Kevin Wolf wrote: +static void null_refresh_limits(BlockDriverState *bs, Error **errp) +{ +bs->bl.request_alignment = 1; +} >>> >>> I would rather modify bdrv_refresh_limits() so that it defaults to 1 for >>> drivers supporting either .bdrv_co_preadv

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

2018-04-24 Thread Kevin Wolf
Am 24.04.2018 um 19:00 hat Eric Blake geschrieben: > On 04/24/2018 10:52 AM, Kevin Wolf wrote: > > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: > >> We are gradually moving away from sector-based interfaces, towards > >> byte-based. Make the change for the last few sector-based callbacks > >

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

2018-04-24 Thread Eric Blake
On 04/24/2018 10:52 AM, Kevin Wolf wrote: > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Make the change for the last few sector-based callbacks >> in the null-co and null-aio drivers. >> >> Note that since

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

2018-04-24 Thread Kevin Wolf
Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based callbacks > in the null-co and null-aio drivers. > > Note that since the null driver does nothing on writes, it trivi

[Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

2018-02-15 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based callbacks in the null-co and null-aio drivers. Note that since the null driver does nothing on writes, it trivially supports the BDRV_REQ_FUA flag (all writes have already