Re: [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path

On Fri, Jan 11, 2013 at 11:24:59AM +0100, Markus Armbruster wrote: > Spotted by Coverity. Also document why we keep it open on success. > > Signed-off-by: Markus Armbruster Reviewed-by: Michael Roth > --- > qga/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qga/main.c b/q

[Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path

Spotted by Coverity. Also document why we keep it open on success. Signed-off-by: Markus Armbruster --- qga/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qga/main.c b/qga/main.c index 1a22d8d..db47427 100644 --- a/qga/main.c +++ b/qga/main.c @@ -286,10 +286,12 @@ static bool ga_o