Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Eduardo Habkost
On Thu, Dec 06, 2012 at 05:02:52PM +0100, Andreas Färber wrote: > Am 06.12.2012 16:42, schrieb Andreas Färber: > > Am 06.12.2012 16:37, schrieb Eduardo Habkost: > >> On Wed, Oct 31, 2012 at 04:04:00AM +0100, Andreas Färber wrote: > >>> Implement alphabetical listing of CPU subclasses. > >>> > >>> S

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Eduardo Habkost
On Thu, Dec 06, 2012 at 03:59:46PM +, Peter Maydell wrote: > On 6 December 2012 15:37, Eduardo Habkost wrote: > > target-arm has very similar code. Isn't it better to first write a > > common reusable function to list CPU models using the list of > > subclasses, instead of adding very similar

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Andreas Färber
Am 06.12.2012 16:42, schrieb Andreas Färber: > Am 06.12.2012 16:37, schrieb Eduardo Habkost: >> On Wed, Oct 31, 2012 at 04:04:00AM +0100, Andreas Färber wrote: >>> Implement alphabetical listing of CPU subclasses. >>> >>> Signed-off-by: Andreas Färber >>> --- >>> target-alpha/cpu.c | 41 +++

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Peter Maydell
On 6 December 2012 15:37, Eduardo Habkost wrote: > target-arm has very similar code. Isn't it better to first write a > common reusable function to list CPU models using the list of > subclasses, instead of adding very similar functions to all > architectures? What would be particularly useful to

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Andreas Färber
Am 06.12.2012 16:37, schrieb Eduardo Habkost: > On Wed, Oct 31, 2012 at 04:04:00AM +0100, Andreas Färber wrote: >> Implement alphabetical listing of CPU subclasses. >> >> Signed-off-by: Andreas Färber >> --- >> target-alpha/cpu.c | 41 + >> target-alpha/c

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-12-06 Thread Eduardo Habkost
On Wed, Oct 31, 2012 at 04:04:00AM +0100, Andreas Färber wrote: > Implement alphabetical listing of CPU subclasses. > > Signed-off-by: Andreas Färber > --- > target-alpha/cpu.c | 41 + > target-alpha/cpu.h |4 +++- > 2 Dateien geändert, 44 Zeilen hin

Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-10-30 Thread Richard Henderson
On 2012-10-31 14:04, Andreas Färber wrote: > Implement alphabetical listing of CPU subclasses. > > Signed-off-by: Andreas Färber There doesn't seem to be anything alpha-specific about this. Does it really need to be replicated? That said, Acked-by: Richard Henderson r~

[Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ?

2012-10-30 Thread Andreas Färber
Implement alphabetical listing of CPU subclasses. Signed-off-by: Andreas Färber --- target-alpha/cpu.c | 41 + target-alpha/cpu.h |4 +++- 2 Dateien geändert, 44 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-alpha/cpu.c b/target-alp