Re: [Qemu-devel] [PATCH 31/38] ivshmem: Inline check_shm_size() into its only caller

2016-03-02 Thread Marc-André Lureau
Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > Improve the error messages while there. > > Signed-off-by: Markus Armbruster > --- I am not convinced this improves readibility much, I would cleanup a bit the function, but keep it. > hw/misc/ivshmem.c | 37 +++---

[Qemu-devel] [PATCH 31/38] ivshmem: Inline check_shm_size() into its only caller

2016-02-29 Thread Markus Armbruster
Improve the error messages while there. Signed-off-by: Markus Armbruster --- hw/misc/ivshmem.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 0440bca..785ed1c 100644 --- a/hw/misc/ivshmem.c +