Re: [Qemu-devel] [PATCH 31/60] AArch64: Add bfm family instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > + > +uint64_t HELPER(sign_extend)(uint64_t x, uint64_t is_signed, uint64_t mask) > +{ > +if (x & is_signed) { > +x |= mask; > +} > + > +return x; > +} Why in the world do you have such a simple helper? > +tcg_gen_andi_i64(tcg

[Qemu-devel] [PATCH 31/60] AArch64: Add bfm family instruction emulation

2013-09-26 Thread Alexander Graf
This patch adds emulation support for BFM and friends (SBFM, UBFM). Signed-off-by: Alexander Graf --- target-arm/helper-a64.c| 9 + target-arm/helper-a64.h| 1 + target-arm/translate-a64.c | 86 +- 3 files changed, 95 insertions(+), 1 del