Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-10-07 Thread Fabien Chouteau
On 10/04/2013 07:52 PM, Peter Maydell wrote: >> +#include "monitor/monitor_def.h" >> + >> +const MonitorDef arm_monitor_defs[] = { >> +{ "r0", offsetof(CPUARMState, regs[0]) }, >> +{ "r1", offsetof(CPUARMState, regs[1]) }, > > These fields are all 32 bits, not target_long, > so t

Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-10-04 Thread Peter Maydell
On 5 October 2013 01:57, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > target-arm/Makefile.objs |2 +- > target-arm/cpu.c |7 +++ > target-arm/monitor.c | 40 > 3 files changed, 48 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-10-04 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- target-arm/Makefile.objs |2 +- target-arm/cpu.c |7 +++ target-arm/monitor.c | 40 3 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 target-arm/monitor.c diff --git a/target

Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-09-30 Thread Peter Maydell
On 1 October 2013 00:57, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > target-arm/Makefile.objs |2 +- > target-arm/cpu.c |5 + > target-arm/monitor.c | 40 > 3 files changed, 46 insertions(+), 1 deletion(-) >

[Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-09-30 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- target-arm/Makefile.objs |2 +- target-arm/cpu.c |5 + target-arm/monitor.c | 40 3 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 target-arm/monitor.c diff --git a/target-a