On Thu 22 Mar 2018 05:12:26 PM CET, Laurent Vivier wrote:
> diff --git a/block/quorum.c b/block/quorum.c
> index 14333c18aa..304442ef65 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -608,7 +608,7 @@ static void read_quorum_children_entry(void *opaque)
> static int read_quorum_children
On Thu, Mar 22, 2018 at 05:12:26PM +0100, Laurent Vivier wrote:
> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> accel/tcg/translate-all.c | 5 +-
> block/quorum.c | 6 +--
On 22 March 2018 at 17:30, Eric Blake wrote:
> I'm less certain of whether our Coccinelle scripts have easy ways to exclude
> specific files. We already have scripts/cocci-macro-file.h to help
> Coccinelle not choke on some our existing files, but I'm not sure if
> Coccinelle has a config-file li
On 03/22/2018 12:19 PM, Max Filippov wrote:
These files were autogenerated, fixing them doesn't make much sense.
Good to know. They have been already updated by a couple of patches:
8f0a3716e4 Clean up includes
d8e39b7062 Use #include "..." for our own headers, <...> for others
Perhaps impor
On Thu, Mar 22, 2018 at 10:23 AM, Peter Maydell
wrote:
> On 22 March 2018 at 17:19, Max Filippov wrote:
>> Ok, I can add a fixup that changes #include to #include
>> "xtensa-isa.h".
>> Adding #include "qemu/osdep.h" there seems pointless to me.
>
> Every top level .c file must start with includi
On 22 March 2018 at 17:19, Max Filippov wrote:
> Ok, I can add a fixup that changes #include to #include
> "xtensa-isa.h".
> Adding #include "qemu/osdep.h" there seems pointless to me.
Every top level .c file must start with including osdep.h.
Other headers that it might include rely on that.
It
On Thu, Mar 22, 2018 at 9:58 AM, Laurent Vivier wrote:
> On 22/03/2018 17:51, Max Filippov wrote:
>> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
>>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> target/xtensa/core-
On Thu, Mar 22, 2018 at 9:59 AM, Eric Blake wrote:
> On 03/22/2018 11:51 AM, Max Filippov wrote:
>>
>> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier
>> wrote:
>>>
>>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> target/xt
On 03/22/2018 11:51 AM, Max Filippov wrote:
On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
target/xtensa/core-dc232b/xtensa-modules.c | 56 ++
target/xten
On 22/03/2018 17:51, Max Filippov wrote:
> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> target/xtensa/core-dc232b/xtensa-modules.c | 56
>> ++
On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> target/xtensa/core-dc232b/xtensa-modules.c | 56
> ++
> target/xtensa/core-dc233c/xtensa-modules.c
On 03/22/2018 11:12 AM, Laurent Vivier wrote:
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
+++ b/hw/arm/exynos4210.c
@@ -156,12 +156,7 @@ void exynos4210_write_secondary(ARMCPU *cpu,
static uint64_t exynos4210_calc_affinity(int cpu)
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
accel/tcg/translate-all.c | 5 +-
block/quorum.c | 6 +--
hw/arm/exynos4210.c| 7 +--
hw/block/vhost
13 matches
Mail list logo