Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-30 Thread Peter Lieven
On 23.09.2014 12:05, Kevin Wolf wrote: Am 23.09.2014 um 11:52 hat Peter Lieven geschrieben: On 23.09.2014 11:47, Kevin Wolf wrote: Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben: On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-30 Thread Kevin Wolf
Am 30.09.2014 um 09:26 hat Peter Lieven geschrieben: On 23.09.2014 12:05, Kevin Wolf wrote: Am 23.09.2014 um 11:52 hat Peter Lieven geschrieben: On 23.09.2014 11:47, Kevin Wolf wrote: Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben: On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Peter Lieven
On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The default for max_transfer_length is 0 (no limit). max_transfer_length is a limit that MUST be satisfied otherwise the request will fail. And Patch 2

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Kevin Wolf
Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The default for max_transfer_length is 0 (no limit). max_transfer_length is a limit that MUST be

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Peter Lieven
On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The default for max_transfer_length is 0 (no limit).

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Peter Lieven
On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The default for max_transfer_length is 0 (no limit).

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Kevin Wolf
Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben: On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Peter Lieven
On 23.09.2014 11:47, Kevin Wolf wrote: Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben: On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-23 Thread Kevin Wolf
Am 23.09.2014 um 11:52 hat Peter Lieven geschrieben: On 23.09.2014 11:47, Kevin Wolf wrote: Am 23.09.2014 um 11:32 hat Peter Lieven geschrieben: On 23.09.2014 10:59, Kevin Wolf wrote: Am 23.09.2014 um 08:15 hat Peter Lieven geschrieben: On 22.09.2014 21:06, Paolo Bonzini wrote: Il 22/09/2014

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-22 Thread Peter Lieven
On 19.09.2014 15:33, Paolo Bonzini wrote: Il 19/09/2014 00:56, Peter Lieven ha scritto: So I think if we treat it just as a hint for multiwrite, we can avoid writing code to split oversized requests. They always worked so far, we can certainly wait until we have a real bug fix. I would not

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 11:43, Peter Lieven ha scritto: This series aims not at touching default behaviour. The default for max_transfer_length is 0 (no limit). max_transfer_length is a limit that MUST be satisfied otherwise the request will fail. And Patch 2 aims at catching this fail earlier in the

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-19 Thread Paolo Bonzini
Il 19/09/2014 00:56, Peter Lieven ha scritto: So I think if we treat it just as a hint for multiwrite, we can avoid writing code to split oversized requests. They always worked so far, we can certainly wait until we have a real bug fix. I would not treat this as a hint. I would use it in

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-18 Thread Paolo Bonzini
Il 05/09/2014 18:51, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index fa4c34b..db3f842 100644 --- a/block.c +++ b/block.c @@ -4554,6 +4554,11 @@ static int

Re: [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-18 Thread Peter Lieven
Am 18.09.2014 um 16:13 schrieb Paolo Bonzini pbonz...@redhat.com: Il 05/09/2014 18:51, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index fa4c34b..db3f842 100644 --- a/block.c

[Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-05 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index fa4c34b..db3f842 100644 --- a/block.c +++ b/block.c @@ -4554,6 +4554,11 @@ static int multiwrite_merge(BlockDriverState *bs, BlockRequest *reqs,