Re: [Qemu-devel] [PATCH 4/4] target-arm: Fix decoding of Thumb preload and hint space

2011-02-03 Thread Peter Maydell
On 3 February 2011 19:43, Peter Maydell wrote: > @@ -8326,9 +8362,8 @@ static int disas_thumb2_insn(CPUState *env, > DisasContext *s, uint16_t insn_hw1) >                 imm = insn & 0xfff; >                 tcg_gen_addi_i32(addr, addr, imm); >             } else { > -                op = (insn

[Qemu-devel] [PATCH 4/4] target-arm: Fix decoding of Thumb preload and hint space

2011-02-03 Thread Peter Maydell
Refine the decoding of the Thumb preload and hint space, so we UNDEF on the patterns that are supposed to UNDEF rather than NOP. We also move the tests for this space earlier, so we don't emit harmless but unnecessary address generation code for preload hints (which by their nature are likely to be