Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-24 Thread Brad Hards
On Thursday 14 April 2011 08:01:43 Brad Hards wrote: > On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote: > > > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice > > > *dev, int configuration) > > > > > > ret = ioctl(dev->fd, USBDEVFS_CLAIMINTERFACE,&interface); >

Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Brad Hards
On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote: > > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice > > *dev, int configuration) > > > > ret = ioctl(dev->fd, USBDEVFS_CLAIMINTERFACE,&interface); > > if (ret< 0) { > > if (errno == EBUSY)

Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Hans de Goede
Hi, On 04/13/2011 11:45 AM, Brad Hards wrote: Signed-off-by: Brad Hards --- usb-linux.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 1f33c2c..b02a0f9 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -233,8 +233,8 @@ stati

Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Stefan Hajnoczi
On Wed, Apr 13, 2011 at 10:45 AM, Brad Hards wrote: > Signed-off-by: Brad Hards > --- >  usb-linux.c |   16 >  1 files changed, 8 insertions(+), 8 deletions(-) Some of these printfs look like they might be useful given that the current USB support is known to be imperfect and fr

[Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Brad Hards
Signed-off-by: Brad Hards --- usb-linux.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 1f33c2c..b02a0f9 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -233,8 +233,8 @@ static void async_complete(void *opaque)