Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-26 Thread Gonglei
On 2015/1/26 20:16, Paolo Bonzini wrote: > > > On 26/01/2015 13:13, Gonglei wrote: That's okay, alternatively you could add a boot_tpgt argument that defaults to 1 (is it correct that 0 is not a valid tpgt?). >> No, 0 is the minimize valid value. :) >> Paolo, where do you thi

Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 13:13, Gonglei wrote: >> > >> > That's okay, alternatively you could add a boot_tpgt argument that >> > defaults to 1 (is it correct that 0 is not a valid tpgt?). >> > > No, 0 is the minimize valid value. :) > Paolo, where do you think we should add a boot_tpgt argument? To vhost

Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-26 Thread Gonglei
On 2015/1/26 17:32, Paolo Bonzini wrote: > > > On 26/01/2015 09:00, Gonglei wrote: >> Hi, Michael & Paolo >> >> Because Qemu only accept an wwpn argument for vhost-scsi, we >> cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu >> doesn't know which tpg can boot, but vhost-scsi dr

Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 09:00, Gonglei wrote: > Hi, Michael & Paolo > > Because Qemu only accept an wwpn argument for vhost-scsi, we > cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu > doesn't know which tpg can boot, but vhost-scsi driver module > doesn't know too for one assigned wwpn

Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-26 Thread Gonglei
On 2015/1/20 5:51, Michael S. Tsirkin wrote: > On Mon, Jan 19, 2015 at 09:23:38PM +0800, arei.gong...@huawei.com wrote: >> > From: Gonglei >> > >> > Because vhost-scsi module do not support VHOST_SCSI_GET_TPGT >> > at present, so I use "#if 0" handle it, and set the target >> > default to 1. In

Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-19 Thread Michael S. Tsirkin
On Mon, Jan 19, 2015 at 09:23:38PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Because vhost-scsi module do not support VHOST_SCSI_GET_TPGT > at present, so I use "#if 0" handle it, and set the target > default to 1. In addition, channel and lun both are 0 for > bootable vhost-scsi

[Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id

2015-01-19 Thread arei.gonglei
From: Gonglei Because vhost-scsi module do not support VHOST_SCSI_GET_TPGT at present, so I use "#if 0" handle it, and set the target default to 1. In addition, channel and lun both are 0 for bootable vhost-scsi device. Signed-off-by: Gonglei Signed-off-by: Bo Su --- hw/scsi/vhost-scsi.c