Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-25 Thread Richard Henderson
On 09/25/2013 12:01 PM, Jeff Cody wrote: > It is from UML, right? Is there an official spec that is still around > (most of the links I have found suffer from link rot)? The closest I > could find to a spec were old UML patches for x86_64 that cleaned up > some data types, so that the following w

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-25 Thread Jeff Cody
On Wed, Sep 25, 2013 at 07:25:20PM +0200, Kevin Wolf wrote: > Am 25.09.2013 um 17:12 hat Jeff Cody geschrieben: > > On Fri, Sep 20, 2013 at 08:23:54AM +0200, Markus Armbruster wrote: > > > Jeff Cody writes: > > > > > > > On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: > > > >>

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-25 Thread Kevin Wolf
Am 25.09.2013 um 17:12 hat Jeff Cody geschrieben: > On Fri, Sep 20, 2013 at 08:23:54AM +0200, Markus Armbruster wrote: > > Jeff Cody writes: > > > > > On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: > > >> On 09/19/2013 11:43 AM, Jeff Cody wrote: > > >> > cow_header_v2 is read

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-25 Thread Jeff Cody
On Fri, Sep 20, 2013 at 08:23:54AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: > >> On 09/19/2013 11:43 AM, Jeff Cody wrote: > >> > cow_header_v2 is read and written directly from the image file > >> > with bdrv_prea

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-19 Thread Markus Armbruster
Jeff Cody writes: > On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: >> On 09/19/2013 11:43 AM, Jeff Cody wrote: >> > cow_header_v2 is read and written directly from the image file >> > with bdrv_pread()/bdrv_pwrite(), and as such should be packed to >> > avoid unintentional pad

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-19 Thread Jeff Cody
On Thu, Sep 19, 2013 at 12:01:24PM -0700, Richard Henderson wrote: > On 09/19/2013 11:43 AM, Jeff Cody wrote: > > cow_header_v2 is read and written directly from the image file > > with bdrv_pread()/bdrv_pwrite(), and as such should be packed to > > avoid unintentional padding. > > > > Also change

Re: [Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-19 Thread Richard Henderson
On 09/19/2013 11:43 AM, Jeff Cody wrote: > cow_header_v2 is read and written directly from the image file > with bdrv_pread()/bdrv_pwrite(), and as such should be packed to > avoid unintentional padding. > > Also change struct cow_header_v2 to a typedef, and some minor > code style changes to keep

[Qemu-devel] [PATCH 4/5] block: cow - used QEMU_PACKED for on-disk structures

2013-09-19 Thread Jeff Cody
cow_header_v2 is read and written directly from the image file with bdrv_pread()/bdrv_pwrite(), and as such should be packed to avoid unintentional padding. Also change struct cow_header_v2 to a typedef, and some minor code style changes to keep checkpatch.pl happy. Signed-off-by: Jeff Cody ---