Re: [Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method

2018-05-29 Thread Cleber Rosa
On 05/29/2018 03:06 PM, Eduardo Habkost wrote: > On Fri, May 25, 2018 at 12:57:54PM -0400, Cleber Rosa wrote: >> On 05/25/2018 01:47 AM, Fam Zheng wrote: > [...] +class QEMU(unittest.TestCase): >>> >>> 'QEMU' is too generic, what is the intended tests to do here? It seems to be >>> more abou

Re: [Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method

2018-05-29 Thread Eduardo Habkost
On Fri, May 25, 2018 at 12:57:54PM -0400, Cleber Rosa wrote: > On 05/25/2018 01:47 AM, Fam Zheng wrote: [...] > >> +class QEMU(unittest.TestCase): > > > > 'QEMU' is too generic, what is the intended tests to do here? It seems to be > > more about exercising the set_console() method. > > > > Yes,

Re: [Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method

2018-05-25 Thread Cleber Rosa
On 05/25/2018 01:47 AM, Fam Zheng wrote: > On Thu, 05/24 20:58, Cleber Rosa wrote: >> The set_console() method is intended to ease higher level use cases >> that require a console device. >> >> The amount of inteligence is limited on purpose, requiring either the >> device type explicitly, or the

Re: [Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method

2018-05-24 Thread Fam Zheng
On Thu, 05/24 20:58, Cleber Rosa wrote: > The set_console() method is intended to ease higher level use cases > that require a console device. > > The amount of inteligence is limited on purpose, requiring either the > device type explicitly, or the existence of a machine (pattern) > definition. >

[Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method

2018-05-24 Thread Cleber Rosa
The set_console() method is intended to ease higher level use cases that require a console device. The amount of inteligence is limited on purpose, requiring either the device type explicitly, or the existence of a machine (pattern) definition. Because of the console device type selection criteri