Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-21 Thread Aurelien Jarno
On Fri, Sep 21, 2012 at 07:33:08AM -0700, Richard Henderson wrote: > On 09/20/2012 03:04 PM, Aurelien Jarno wrote: > > +} else if (tmp && temps[args[4-tmp]].state == > > TCG_TEMP_CONST) { > > No need to test tmp here... Good catch, it's a leftover from a previous version. > But

Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-21 Thread Richard Henderson
On 09/20/2012 03:04 PM, Aurelien Jarno wrote: > +} else if (tmp && temps[args[4-tmp]].state == > TCG_TEMP_CONST) { No need to test tmp here... But thanks for the patch. It'll be included in the next version. r~

Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-20 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 11:11:48PM +0200, Aurelien Jarno wrote: > On Tue, Sep 18, 2012 at 07:23:59AM -0700, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > > --- > > tcg/optimize.c | 29 + > > 1 file changed, 29 insertions(+) > > > > diff --git a/tcg/o

Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-18 Thread Aurelien Jarno
On Tue, Sep 18, 2012 at 07:23:59AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index fba0ed9..5b0a8ce 100644 > --- a/tcg/optimiz

[Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index fba0ed9..5b0a8ce 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -397,6 +397,14 @@ static TCGArg *tcg_constant_folding(T