Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-10-11 Thread Riku Voipio
Hi, This patch doesn't compile for me on ubuntu 12.04 x86_64 host: CClinux-user/signal.o /home/voipio/test/qemu/linux-user/signal.c: In function ‘do_sigaction’: /home/voipio/test/qemu/linux-user/signal.c:620:9: error: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer t

[Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-21 Thread Richard Henderson
Unconditional bswap replaced by __get_user/__put_user. Signed-off-by: Richard Henderson --- linux-user/signal.c | 22 -- linux-user/syscall_defs.h | 2 +- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 78

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Richard Henderson
On 2012-09-16 05:58, Andreas Färber wrote: > Am 15.09.2012 22:24, schrieb Richard Henderson: >> Unconditional bswap replaced by __get_user/__put_user. >> >> Signed-off-by: Richard Henderson > > Does that still take care of swapping with the correct size? Yes, and automatically too. > The issue

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Peter Maydell
On 16 September 2012 13:58, Andreas Färber wrote: > Am 15.09.2012 22:24, schrieb Richard Henderson: >> Unconditional bswap replaced by __get_user/__put_user. >> >> Signed-off-by: Richard Henderson > > Does that still take care of swapping with the correct size? Yes; they do target-swapping based

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Andreas Färber
Am 15.09.2012 22:24, schrieb Richard Henderson: > Unconditional bswap replaced by __get_user/__put_user. > > Signed-off-by: Richard Henderson Does that still take care of swapping with the correct size? The issue for mips was that some oddballs are 32-bit, others long. Please make sure that mip

[Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-15 Thread Richard Henderson
Unconditional bswap replaced by __get_user/__put_user. Signed-off-by: Richard Henderson --- linux-user/signal.c | 22 -- linux-user/syscall_defs.h | 2 +- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 78