On 28.08.19 23:28, Richard Henderson wrote:
> On 8/26/19 1:41 AM, David Hildenbrand wrote:
>>> -/* Make accesses to pages with watchpoints go via the
>>> - watchpoint trap routines. */
>>> -QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {
>>> -if (cpu_watchpoint_address_matches
On 8/26/19 1:41 AM, David Hildenbrand wrote:
>> -/* Make accesses to pages with watchpoints go via the
>> - watchpoint trap routines. */
>> -QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {
>> -if (cpu_watchpoint_address_matches(wp, vaddr, TARGET_PAGE_SIZE)) {
>> -/
On 24.08.19 23:34, Richard Henderson wrote:
> We want to move the check for watchpoints from
> memory_region_section_get_iotlb to tlb_set_page_with_attrs.
> Isolate the loop over watchpoints to an exported function.
>
> Rename the existing cpu_watchpoint_address_matches to
> watchpoint_address_mat
We want to move the check for watchpoints from
memory_region_section_get_iotlb to tlb_set_page_with_attrs.
Isolate the loop over watchpoints to an exported function.
Rename the existing cpu_watchpoint_address_matches to
watchpoint_address_matches, since it doesn't actually
have a cpu argument.
Si