Re: [Qemu-devel] [PATCH 4/6] exec: Factor out cpu_watchpoint_address_matches

2019-08-28 Thread David Hildenbrand
On 28.08.19 23:28, Richard Henderson wrote: > On 8/26/19 1:41 AM, David Hildenbrand wrote: >>> -/* Make accesses to pages with watchpoints go via the >>> - watchpoint trap routines. */ >>> -QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { >>> -if (cpu_watchpoint_address_matches

Re: [Qemu-devel] [PATCH 4/6] exec: Factor out cpu_watchpoint_address_matches

2019-08-28 Thread Richard Henderson
On 8/26/19 1:41 AM, David Hildenbrand wrote: >> -/* Make accesses to pages with watchpoints go via the >> - watchpoint trap routines. */ >> -QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { >> -if (cpu_watchpoint_address_matches(wp, vaddr, TARGET_PAGE_SIZE)) { >> -/

Re: [Qemu-devel] [PATCH 4/6] exec: Factor out cpu_watchpoint_address_matches

2019-08-26 Thread David Hildenbrand
On 24.08.19 23:34, Richard Henderson wrote: > We want to move the check for watchpoints from > memory_region_section_get_iotlb to tlb_set_page_with_attrs. > Isolate the loop over watchpoints to an exported function. > > Rename the existing cpu_watchpoint_address_matches to > watchpoint_address_mat

[Qemu-devel] [PATCH 4/6] exec: Factor out cpu_watchpoint_address_matches

2019-08-24 Thread Richard Henderson
We want to move the check for watchpoints from memory_region_section_get_iotlb to tlb_set_page_with_attrs. Isolate the loop over watchpoints to an exported function. Rename the existing cpu_watchpoint_address_matches to watchpoint_address_matches, since it doesn't actually have a cpu argument. Si