Re: [Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 04:45 AM, Andrew Jeffery wrote: > On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: >> aspeed_init() now uses a board identifier to customize some values >> specific to the board, ram base, board revision number, etc. >> >> Signed-off-by: Cédric Le Goater >

Re: [Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

2016-07-27 Thread Andrew Jeffery
On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: > aspeed_init() now uses a board identifier to customize some values > specific to the board, ram base, board revision number, etc. > > Signed-off-by: Cédric Le Goater Looks okay to me, some minor comments below: > --- >

[Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

2016-07-27 Thread Cédric Le Goater
aspeed_init() now uses a board identifier to customize some values specific to the board, ram base, board revision number, etc. Signed-off-by: Cédric Le Goater --- hw/arm/palmetto-bmc.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-)