Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2013-01-04 Thread Stefan Hajnoczi
On Fri, Dec 21, 2012 at 06:20:40AM +, Dietmar Maurer wrote: If libvirt could integrate external tool using code, that would be great. For qemu, My understanding is just to take internal snapshot and stop vm, You just need to save VM state, flush all IO requests, then stop.

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-24 Thread Wenchao Xia
Every request's handler need to have three function: execution, updating, cancelling. Also another check function canceling OK. could be provided to check if request is valid before execition. internal snapshot implemention was based on the code from diet...@proxmox.com.

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-21 Thread Juan Quintela
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch is the implemention of transaction based snapshot internal API. Internal snapshot for specified block device is added, which can be used as part of functionality in one way to live full back up vm seperating internal block snapshot and

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Eric Blake
On 12/17/2012 02:58 AM, Dietmar Maurer wrote: Seems this makes it impossible to use external commands to make snapshots? what command? can you tip more about the case? For example, nexenta storage provides an API to create snapshots. We want to use that. Another example would be to use

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Wenchao Xia
于 2012-12-21 6:19, Eric Blake 写道: On 12/17/2012 02:58 AM, Dietmar Maurer wrote: Seems this makes it impossible to use external commands to make snapshots? what command? can you tip more about the case? For example, nexenta storage provides an API to create snapshots. We want to use

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Dietmar Maurer
If libvirt could integrate external tool using code, that would be great. For qemu, My understanding is just to take internal snapshot and stop vm, You just need to save VM state, flush all IO requests, then stop. After that the management framework can issue command to: * create

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Wenchao Xia
于 2012-12-17 18:32, Dietmar Maurer 写道: For example, nexenta storage provides an API to create snapshots. We want to use that. Another example would be to use lvcreate to create lvm snapshots. I am not familar with those tools You do not know LVM? Honest speaking I use LVM tools

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Dietmar Maurer
I am not familar with those tools You do not know LVM? Honest speaking I use LVM tools little. I wonder why lvcreate can't be used, for block internal snapshot I think this patch have same function as your previous patch, what is missing? Qemu does not have any information

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Wenchao Xia
于 2012-12-18 18:36, Dietmar Maurer 写道: I am not familar with those tools You do not know LVM? Honest speaking I use LVM tools little. I wonder why lvcreate can't be used, for block internal snapshot I think this patch have same function as your previous patch, what is missing?

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Dietmar Maurer
OK, I think underlying storage is another level of issue, just wondering what this patch miss to stop you use external tool, did you called a LVM/nexenta C API in previous patch? The trick is to do thing step by step 1.) save state 2.) create internal snapshots 3.) call external tools to

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Wenchao Xia
于 2012-12-19 12:55, Dietmar Maurer 写道: OK, I think underlying storage is another level of issue, just wondering what this patch miss to stop you use external tool, did you called a LVM/nexenta C API in previous patch? The trick is to do thing step by step 1.) save state 2.) create internal

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Wenchao Xia
于 2012-12-17 15:52, Dietmar Maurer 写道: 于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Dietmar Maurer
Seems this makes it impossible to use external commands to make snapshots? what command? can you tip more about the case? For example, nexenta storage provides an API to create snapshots. We want to use that. Another example would be to use lvcreate to create lvm snapshots.

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Dietmar Maurer
For example, nexenta storage provides an API to create snapshots. We want to use that. Another example would be to use lvcreate to create lvm snapshots. I am not familar with those tools You do not know LVM?

[Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Wenchao Xia
This patch is the implemention of transaction based snapshot internal API. Internal snapshot for specified block device is added, which can be used as part of functionality in one way to live full back up vm seperating internal block snapshot and vmstate(vmstate goes to another file, not

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Dietmar Maurer
This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Seems this makes it impossible to use external commands to make snapshots?

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Wenchao Xia
于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you referring? In group case a check should be

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Dietmar Maurer
于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you referring? I refer to: