Re: [Qemu-devel] [PATCH 4/6] target/m68k: add moves

2018-01-10 Thread Richard Henderson
On 01/08/2018 03:10 PM, Laurent Vivier wrote: > and introduce SFC and DFC control registers. > > Signed-off-by: Laurent Vivier The patch is correct, so Reviewed-by: Richard Henderson However... > +void HELPER(moves_store)(CPUM68KState *env, uint32_t val, > + uint32_t

[Qemu-devel] [PATCH 4/6] target/m68k: add moves

2018-01-08 Thread Laurent Vivier
and introduce SFC and DFC control registers. Signed-off-by: Laurent Vivier --- target/m68k/cpu.h | 2 ++ target/m68k/helper.c| 82 + target/m68k/helper.h| 2 ++ target/m68k/monitor.c | 2 ++ target/m68k/op_helper.c | 4 +-- targ