Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
Alex, some more answers for a couple of leftovers. Heinz On Mon, 2012-07-30 at 15:24 +0200, Alexander Graf wrote: > On 24.07.2012, at 09:37, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those events don't > > provide SCLP co

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
On Tue, 2012-07-31 at 14:59 +0200, Andreas Färber wrote: > Am 24.07.2012 09:37, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those events don't > > provide SCLP commands on their own, instead they are all based on > > Read Even

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-03 Thread Christian Borntraeger
On 31/07/12 14:59, Andreas Färber wrote: >> +typedef struct EventTypes { >> +BusState qbus; >> +SCLPEventFacility *event_facility; >> +} EventTypes; >> + >> +struct SCLPEventFacility { >> +EventTypes sbus; >> +DeviceState *qdev; >> +/* guest' receive mask */ >> +unsigned int

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-31 Thread Andreas Färber
Am 24.07.2012 09:37, schrieb Christian Borntraeger: > From: Heinz Graalfs > > Several SCLP features are considered to be events. Those events don't > provide SCLP commands on their own, instead they are all based on > Read Event Data, Write Event Data, Write Event Mask and the service > interrupt

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-30 Thread Alexander Graf
On 30.07.2012, at 16:46, Christian Borntraeger wrote: > On 30/07/12 15:24, Alexander Graf wrote: > > Thanks for the review. > > Here is just a short answer regarding the interrupt, we will adress the other > comments in a later > mail. > >>> void sclp_service_interrupt(uint32_t sccb) >>> { >>

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-30 Thread Christian Borntraeger
On 30/07/12 15:24, Alexander Graf wrote: Thanks for the review. Here is just a short answer regarding the interrupt, we will adress the other comments in a later mail. >> void sclp_service_interrupt(uint32_t sccb) >> { >> -if (!sccb) { >> +SCLPEventFacility *ef = sbus->event_facility->i

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-30 Thread Alexander Graf
On 24.07.2012, at 09:37, Christian Borntraeger wrote: > From: Heinz Graalfs > > Several SCLP features are considered to be events. Those events don't > provide SCLP commands on their own, instead they are all based on > Read Event Data, Write Event Data, Write Event Mask and the service > inter

[Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-24 Thread Christian Borntraeger
From: Heinz Graalfs Several SCLP features are considered to be events. Those events don't provide SCLP commands on their own, instead they are all based on Read Event Data, Write Event Data, Write Event Mask and the service interrupt. Follow-on patches will provide SCLP's Signal Quiesce (via syst