Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-11 Thread David Gibson
On Thu, Oct 11, 2012 at 04:07:24PM +0100, Peter Maydell wrote: > On 11 October 2012 02:57, David Gibson wrote: > > Actually, turns out I had another use of these helpers. That was to > > store the real page address from the ppcmeb_tlb_t structure. That > > structure is used to represent TLB entr

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-11 Thread Peter Maydell
On 11 October 2012 02:57, David Gibson wrote: > Actually, turns out I had another use of these helpers. That was to > store the real page address from the ppcmeb_tlb_t structure. That > structure is used to represent TLB entries on a number of different > embedded chips, which don't all have the

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-10 Thread David Gibson
On Wed, Oct 10, 2012 at 11:17:31AM +1100, David Gibson wrote: > On Tue, Oct 09, 2012 at 05:24:29PM +0100, Peter Maydell wrote: > > On 9 October 2012 13:53, David Gibson wrote: > > > Well, the place I've used this (in patches yet to be posted) is saving > > > the state of the pseries machine itself

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-09 Thread David Gibson
On Tue, Oct 09, 2012 at 05:24:29PM +0100, Peter Maydell wrote: > On 9 October 2012 13:53, David Gibson wrote: > > Well, the place I've used this (in patches yet to be posted) is saving > > the state of the pseries machine itself. Specifically, I use > > VMSTATE_TPA_EQUAL to sanity check that the

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-09 Thread Peter Maydell
On 9 October 2012 13:53, David Gibson wrote: > Well, the place I've used this (in patches yet to be posted) is saving > the state of the pseries machine itself. Specifically, I use > VMSTATE_TPA_EQUAL to sanity check that the restored machine has the > same ram size as the saved machine. This do

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-09 Thread David Gibson
On Tue, Oct 09, 2012 at 09:03:21AM +0100, Peter Maydell wrote: > On 9 October 2012 05:53, David Gibson wrote: > > The savevm code contains VMSTATE_ helpers for a number of commonly used > > types, but not for target_phys_addr_t. This patch fixes that deficiency > > implementing VMSTATE_TPA helper

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-09 Thread Peter Maydell
On 9 October 2012 05:53, David Gibson wrote: > The savevm code contains VMSTATE_ helpers for a number of commonly used > types, but not for target_phys_addr_t. This patch fixes that deficiency > implementing VMSTATE_TPA helpers in terms of VMSTATE_UINT32 or > VMSTATE_UINT64 helpers as appropriate

[Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-08 Thread David Gibson
The savevm code contains VMSTATE_ helpers for a number of commonly used types, but not for target_phys_addr_t. This patch fixes that deficiency implementing VMSTATE_TPA helpers in terms of VMSTATE_UINT32 or VMSTATE_UINT64 helpers as appropriate. Signed-off-by: David Gibson --- targphys.h | 11