Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-04 Thread Richard Henderson
On Mar 4, 2016 04:41, Paolo Bonzini wrote: > Any thoughts about patch 7? > > Paolo I think I like my version, since it unifies the code testing and setting the bit.  I was planning to refresh the series on Saturday; feel free to do a pull request earlier if you want. r~

Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-04 Thread Paolo Bonzini
On 03/03/2016 20:06, Richard Henderson wrote: > On 03/03/2016 02:08 AM, Paolo Bonzini wrote: >>> Do you want LOG_UNIMP or LOG_GUEST_ERROR? >> >> I would actually use LOG_IN_ASM. As you noticed, guests sometimes use >> illegal opcodes; another example is Xen's hypercall interface. >> >> On 03/03/

Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-04 Thread Paolo Bonzini
On 03/03/2016 20:06, Richard Henderson wrote: > On 03/03/2016 02:08 AM, Paolo Bonzini wrote: >>> Do you want LOG_UNIMP or LOG_GUEST_ERROR? >> >> I would actually use LOG_IN_ASM. As you noticed, guests sometimes use >> illegal opcodes; another example is Xen's hypercall interface. >> >> On 03/03/

Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-03 Thread Richard Henderson
On 03/03/2016 02:08 AM, Paolo Bonzini wrote: Do you want LOG_UNIMP or LOG_GUEST_ERROR? I would actually use LOG_IN_ASM. As you noticed, guests sometimes use illegal opcodes; another example is Xen's hypercall interface. On 03/03/2016 07:57, Hervé Poussineau wrote: This patch is not quiet on

Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-03 Thread Paolo Bonzini
> Do you want LOG_UNIMP or LOG_GUEST_ERROR? I would actually use LOG_IN_ASM. As you noticed, guests sometimes use illegal opcodes; another example is Xen's hypercall interface. On 03/03/2016 07:57, Hervé Poussineau wrote: > This patch is not quiet on some operating systems: > OS/2: > ILLOPC: 00

Re: [Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-02 Thread Hervé Poussineau
Le 03/03/2016 06:30, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- target-i386/translate.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index b73c237..aa423cb 100644 --- a/targe

[Qemu-devel] [PATCH 4/7] target-i386: Dump illegal opcodes with -d unimp

2016-03-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/translate.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index b73c237..aa423cb 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -