Re: [Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-21 Thread Paolo Bonzini
Il 20/01/2014 17:41, Eduardo Habkost ha scritto: > -eax = kvm_arch_get_supported_cpuid(s, 0xC000, 0, R_EAX); > -if (eax >= 0xC001) { > -/* Support VIA max extended level */ > -x86_cpu_def->xlevel2 = eax; > -x86_cpu_def->features[FEAT_C000_0001_EDX] = > -

Re: [Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-20 Thread Andreas Färber
Am 20.01.2014 17:41, schrieb Eduardo Habkost: > There's no need to check CPU xlevel2 before calling > kvm_arch_get_supported_cpuid(s, 0xC001, 0, R_EDX), because: > > * The kernel won't return any entry for 0xC000 if host CPU vendor >is not Centaur (See kvm_dev_ioctl_get_supported_cpui

[Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-20 Thread Eduardo Habkost
There's no need to check CPU xlevel2 before calling kvm_arch_get_supported_cpuid(s, 0xC001, 0, R_EDX), because: * The kernel won't return any entry for 0xC000 if host CPU vendor is not Centaur (See kvm_dev_ioctl_get_supported_cpuid() on the kernel code) * Similarly, the kernel won'