Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Kevin O'Connor
On Wed, Dec 09, 2015 at 10:54:38AM -0800, Peter Crosthwaite wrote: > On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Tuesday, 8 December 2015 23:40 > >> On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann > >> wrote:

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Crosthwaite
On Wed, Dec 9, 2015 at 1:01 PM, Peter Maydell wrote: > On 9 December 2015 at 18:54, Peter Crosthwaite > wrote: >> On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann >> wrote: From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] Is that more likely to be an IP connectivity problem (

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, 9 December 2015 13:01 > On 9 December 2015 at 18:54, Peter Crosthwaite > wrote: > > On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann > > wrote: > >>> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >>> Is that

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Maydell
On 9 December 2015 at 18:54, Peter Crosthwaite wrote: > On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann > wrote: >>> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >>> Is that more likely to be an IP connectivity problem (wierd input to >>> the card-detect pin in the SoC)? >> >> That

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Wednesday, 9 December 2015 10:55 > > Yes, that's the same change I made. Is it going to be applied? > > > > It missed the boat for 2.5, but you could help by putting a tested-by > or reviewed-by to the patch. Ok. > > The compl

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Crosthwaite
On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Tuesday, 8 December 2015 23:40 >> On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann >> wrote: >> >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> >> Sent:

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 8 December 2015 23:40 > On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Saturday, 5 December 2015 21:26 > >> Is this IP just SDHCI? We

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-08 Thread Peter Crosthwaite
On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Saturday, 5 December 2015 21:26 >> Is this IP just SDHCI? We already model SDHCI in QEMU, see >> hw/sd/sdhci.c. If there are RPi specific features to the SDHCI >> implemen

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-08 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, 5 December 2015 21:26 > Is this IP just SDHCI? We already model SDHCI in QEMU, see > hw/sd/sdhci.c. If there are RPi specific features to the SDHCI > implementation they should be added as optional extensions (probababl

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-05 Thread Peter Crosthwaite
On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann wrote: > Signed-off-by: Andrew Baumann > --- > hw/sd/Makefile.objs | 1 + > hw/sd/bcm2835_emmc.c | 800 > +++ > include/hw/sd/bcm2835_emmc.h | 56 +++ > 3 files changed, 857 insertions(+)

[Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-03 Thread Andrew Baumann
Signed-off-by: Andrew Baumann --- hw/sd/Makefile.objs | 1 + hw/sd/bcm2835_emmc.c | 800 +++ include/hw/sd/bcm2835_emmc.h | 56 +++ 3 files changed, 857 insertions(+) create mode 100644 hw/sd/bcm2835_emmc.c create mode 100644 include/h