Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-05-09 Thread Ladi Prosek
On Tue, May 9, 2017 at 4:02 PM, Gerd Hoffmann wrote: > Hi, > >> #4 cpu_physical_memory_snapshot_get_dirty (snap=0x56a3b3d0, >> start=2148532224, length=511) > > https://patchwork.ozlabs.org/patch/760013/ Awesome, thanks! > cheers, > Gerd

Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-05-09 Thread Gerd Hoffmann
Hi, > #4 cpu_physical_memory_snapshot_get_dirty (snap=0x56a3b3d0, > start=2148532224, length=511) https://patchwork.ozlabs.org/patch/760013/ cheers, Gerd

Re: [Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-05-09 Thread Ladi Prosek
Hi Gerd, On Fri, Apr 21, 2017 at 11:16 AM, Gerd Hoffmann wrote: > The vga code clears the dirty bits *after* reading the framebuffer > memory. So if the guest framebuffer updates hits the race window > between vga reading the framebuffer and vga clearing the dirty bits > vga

[Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-04-21 Thread Gerd Hoffmann
The vga code clears the dirty bits *after* reading the framebuffer memory. So if the guest framebuffer updates hits the race window between vga reading the framebuffer and vga clearing the dirty bits vga will miss that update Fix it by using the new memory_region_copy_and_clear_dirty()